Implementation Plan: T5-P4-A1-WP1 Create BackendCmdBuilderBase with Shared Env Assembly#4088
Closed
Trecek wants to merge 2 commits into
Closed
Conversation
Create _backend_cmd_builder_base.py module with BackendCmdBuilderBase ABC and FlagVocabulary NamedTuple. The base class exclusively owns the eight shared env keys (MAX_MCP_OUTPUT_TOKENS, MCP_CONNECTION_NONBLOCKING, CAMPAIGN_ID_ENV_VAR, KITCHEN_SESSION_ID_ENV_VAR, SCENARIO_STEP_NAME, AUTOSKILLIT_ALLOWED_WRITE_PREFIX, AUTOSKILLIT_ALLOWED_WRITE_PREFIXES, AUTOSKILLIT_CWD) previously duplicated across four call sites. Both ClaudeCodeBackend and CodexBackend now inherit from the base and contribute backend-specific extension points (_binary, _sandbox_default, _env_policy, _flag_vocabulary). The _codex_exec_extras shim is preserved for backward compat — it now handles only Codex-specific keys, while the eight shared keys come from self._assemble_shared_env_extras(). Behavioral change: Claude's build_food_truck_cmd now forwards CAMPAIGN_ID_ENV_VAR when present, aligning with Codex's food truck path and Claude's skill session path (both of which already forwarded it). Add test_backend_cmd_builder_base.py covering FlagVocabulary structure, env assembly round-trips, config unpacking (18 fields), inheritance, and extension points. Update execution/backends/AGENTS.md to list the new module.
…ne exemption Add 'claude' and 'codex' to SINGLETON_ALLOWED_MODULES for the CLAUDE_FLAG_VOCABULARY and CODEX_FLAG_VOCABULARY module-level NamedTuple constants introduced by BackendCmdBuilderBase inheritance wiring. Bump execution/backends/codex.py exemption from 1060→1070 to account for the four abstract property implementations added to CodexBackend (+5 net lines). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Closing as superseded — this work already landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create
BackendCmdBuilderBaseABC in a new_backend_cmd_builder_base.pymodule that exclusively owns the eight shared env keys currently duplicated across four call sites inclaude.pyandcodex.py. IntroduceFlagVocabularyNamedTuple to capture per-backend flag structure. Wire bothClaudeCodeBackendandCodexBackendas subclasses. Demote_codex_exec_extrasto a shim by having callers obtain shared keys from the base class method instead.Closes #4014
Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260611-233958-268497/.autoskillit/temp/make-plan/t5-p4-a1-wp1-create-backend-cmd-builder-base_plan_2026-06-11_234500.md🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
* Step used a non-Anthropic provider; caching behavior may differ.
Token Efficiency
Model Usage Breakdown